Dont install pyface from git source #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of installing it from git source modified: ci-src-requirements.txt modified: etstool.py
rahulporuri
changed the title
|
Same as enthought/pyface#787 |
…use-pkg-from-source
kitchoi
reviewed
Nov 2, 2020
modified: etstool.py
rahulporuri
requested review from
kitchoi
and removed request for
corranwebster
kitchoi
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
Offline discussion: @corranwebster confirmed to go ahead with installing released Pyface for TraitsUI CI, he also said we may need to switch back to installing Pyface master for some tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1382
This PR updates CI/etstool to install pyface using edm instead of installing it from git source.