-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump vtprotobuf dependency #33365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
Approval required for changes to Envoy's external dependencies
label
Apr 5, 2024
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
howardjohn
added a commit
to howardjohn/go-control-plane
that referenced
this pull request
Apr 5, 2024
Goes along with envoyproxy/envoy#33365. This will be required to pull in that Envoy change, but it can merge before it.
howardjohn
added a commit
to howardjohn/go-control-plane
that referenced
this pull request
Apr 5, 2024
Goes along with envoyproxy/envoy#33365. This will be required to pull in that Envoy change, but it can merge before it. Signed-off-by: John Howard <[email protected]>
howardjohn
force-pushed
the
deps/vt-proto-bump
branch
from
April 5, 2024 17:22
51d8daf
to
f9dfdb8
Compare
howardjohn
added a commit
to howardjohn/go-control-plane
that referenced
this pull request
Apr 5, 2024
Goes along with envoyproxy/envoy#33365. This will be required to pull in that Envoy change, but it can merge before it. Signed-off-by: John Howard <[email protected]>
howardjohn
added a commit
to howardjohn/go-control-plane
that referenced
this pull request
Apr 5, 2024
Goes along with envoyproxy/envoy#33365. This will be required to pull in that Envoy change, but it can merge before it. Signed-off-by: John Howard <[email protected]>
This picks up a few bug fixes and allows us to remove our build tag hacks Signed-off-by: John Howard <[email protected]>
howardjohn
force-pushed
the
deps/vt-proto-bump
branch
from
April 5, 2024 19:18
f9dfdb8
to
a0448f5
Compare
RyanTheOptimist
approved these changes
Apr 8, 2024
repokitteh-read-only
bot
removed
the
deps
Approval required for changes to Envoy's external dependencies
label
Apr 8, 2024
phlax
pushed a commit
to envoyproxy/go-control-plane
that referenced
this pull request
Apr 8, 2024
Goes along with envoyproxy/envoy#33365. This will be required to pull in that Envoy change, but it can merge before it. Signed-off-by: John Howard <[email protected]>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
This picks up a few bug fixes and allows us to remove our build tag hacks Signed-off-by: John Howard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: build: bump vtprotobuf dependency
Additional Description: This picks up a few bug fixes and allows us to remove our build tag hacks
Risk Level: LOW
Testing: Manually tested build + import into go-control-plane
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]