Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mobile]expose onNetworkTypeChanged API to Engine #36504

Merged
merged 1 commit into from
Oct 9, 2024

expose onNetworkTypeChanged api

23f589d
Select commit
Loading
Failed to load commit list.
Merged

[mobile]expose onNetworkTypeChanged API to Engine #36504

expose onNetworkTypeChanged api
23f589d
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Checks succeeded Oct 8, 2024 in 17m 59s

Envoy/Checks (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Envoy/Checks (pr/36504/main@23f589d)

Check started by

Request (pr/36504/main@23f589d)

RenjieTang @RenjieTang 23f589d #36504 merge main@5773309

[mobile]expose onNetworkTypeChanged API to Engine

Commit Message: expose onNetworkTypeChanged API to Engine
Additional Description: This prevents applications from directly depending on InternalEngine.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile only

Environment

Request variables

Key Value
ref c6253e4
sha 23f589d
pr 36504
base-sha 5773309
actor RenjieTang @RenjieTang
message [mobile]expose onNetworkTypeChanged API to Engine...
started 1728430339.466527
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true