docs: update lyft/envoy-build readme #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci/build_container/README.md
Outdated
| the envoy-build container with the current state of `build_container.sh`, tag the image | ||
| with the SHA provided, and push it to Dockerhub. | ||
| 4. After you have done that, update `ci/ci_steps.sh` to pull the new tagged version of `lyft/envoy-build`. | ||
| the envoy-build container with the current state of `build_container.sh`, tag the image, and push it to Dockerhub.: |
|
i'll go though this now |
|
Looks pretty straightforward to me, just went through it. |
RomanDzhabarov
approved these changes
Feb 15, 2017
alyssawilk
pushed a commit
that referenced
this pull request
Feb 12, 2018
Description: If the xff_num_trusted_hops config option is set to a number greater than zero, trust the specified number of additional addresses at the end of the X-Forwarded-For request header. Risk Level: High (because this change interacts with the internal/external request security model) Testing: New test cases included Docs Changes: #479 Release Notes: Included Fixes: #2503 API Changes: #459 Signed-off-by: Brian Pane [email protected]
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…lter.rst (envoyproxy#479) * envoyproxy#354 translate dynamodb_filter * envoyproxy#354 zh-translation: docs/root/configuration/http/http_filters/dynamodb_filter.rst, fix * envoyproxy#354 zh-translation: docs/root/configuration/http/http_filters/dynamodb_filter.rst, fix review comment Co-authored-by: niushaohan <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
* bazel: update release config This changes the release config to use bazel's compilation_mode=opt which implies the necessary optimization options, and some other things. This also removes the linkopt that appears to do nothing, and requires you pass some configuration about architectures separately. Signed-off-by: Keith Smiley <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
This reverts commit 4647e878fa945dcf3a3a38f7159b58f5cd890662. We noticed when building with these new release options that builds fail with the following errors: ``` Uncompressed input jar has size 18446744072925756006, which exceeds the maximum supported output size 4294967295. Assuming that ijar will be smaller and hoping for the best. Target //:ios_dist failed to build ``` Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
* bazel: update release config This changes the release config to use bazel's compilation_mode=opt which implies the necessary optimization options, and some other things. This also removes the linkopt that appears to do nothing, and requires you pass some configuration about architectures separately. Signed-off-by: Keith Smiley <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
This reverts commit 4647e878fa945dcf3a3a38f7159b58f5cd890662. We noticed when building with these new release options that builds fail with the following errors: ``` Uncompressed input jar has size 18446744072925756006, which exceeds the maximum supported output size 4294967295. Assuming that ijar will be smaller and hoping for the best. Target //:ios_dist failed to build ``` Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.