Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update lyft/envoy-build readme #479

Merged
merged 3 commits into from
Feb 15, 2017
Merged

docs: update lyft/envoy-build readme #479

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0de222e
docs: update lyft/envoy-build readme
junr03 Feb 14, 2017
b787057
Update README.md
junr03 Feb 14, 2017
6877201
comment
junr03 Feb 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ci/build_container/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
After you have made changes to `build_container.sh` and merge them to master:

1. Checkout master and pull latest changes.
2. Get the SHA of the master commit of your changes to `build_container.sh`.
3. From `~/envoy/ci/build_container` run `update_build_container.sh`. **Make sure to have
2. From `~/envoy/ci/build_container` run `update_build_container.sh`. **Make sure to have
DOCKER_USERNAME and DOCKER_PASSWORD environment variables set**. This script will build
the envoy-build container with the current state of `build_container.sh`, tag the image
with the SHA provided, and push it to Dockerhub.
4. After you have done that, update `ci/ci_steps.sh` to pull the new tagged version of `lyft/envoy-build`.
the envoy-build container with the current state of `build_container.sh`, tag the image, and push it to Dockerhub:
```
~/envoy/ci/build_container $ DOCKER_USERNAME=user DOCKER_PASSWORD=pass ./update_build_container.sh
```
3. After you have done that, update `ci/ci_steps.sh` in a new PR to pull the new tagged version of `lyft/envoy-build` during CI runs. Any PRs that depend on this image change will have to merge master after the change to `ci/ci_steps.sh` has been merged to master.