enable build on Arm64

[lubinsz]

Signed-off-by: Bin Lu [email protected]

Build for Linux on Arm.
Fix 2 issues:
1, luajit 2.0 does not support for arm/ppc64le
2, fix a bug in source/exe/signal_action.cc

Please see log as reference:

A.
root@entos-thunderx2-02:/go/lubinsz/envoy# uname -m
aarch64
B.
root@entos-thunderx2-02:/go/lubinsz/envoy# bazel build //source/exe:envoy-static

INFO: Analysed target //source/exe:envoy-static (1 packages loaded).
INFO: Found 1 target...
Target //source/exe:envoy-static up-to-date:
bazel-bin/source/exe/envoy-static
INFO: Elapsed time: 26.244s, Critical Path: 7.64s
INFO: 3 processes: 3 linux-sandbox.
INFO: Build completed successfully, 6 total actions
C.
root@entos-thunderx2-02:/go/lubinsz/envoy# file bazel-bin/source/exe/envoy-static
bazel-bin/source/exe/envoy-static: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, BuildID[sha1]=bde20afe9d93c34411f43a50468426e8ac996df9, not stripped

Risk Level: Medium

Testing: unit test,integration

Docs Changes: None

Release Notes: None

[moderation]

I'm building with unpatched Bazel and rules_go on Arm64 without issue. I compile out Luajit with the diff below. I guess it would be nice to have the Lua capability.

diff --git a/WORKSPACE b/WORKSPACE
index 32547b75..a3bb33d0 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -3,7 +3,9 @@ workspace(name = "envoy")
 load("//bazel:repositories.bzl", "envoy_dependencies", "GO_VERSION")
 load("//bazel:cc_configure.bzl", "cc_configure")

-envoy_dependencies()
+envoy_dependencies(
+    skip_targets=['luajit']
+)
 cc_configure()

[dnoe]

Can you retrigger CI as described at the bottom of https://github.com/envoyproxy/envoy/blob/b278115e87de864267a88c689dccd01fb1b9b3df/CONTRIBUTING.md ?

[lubinsz]

@moderation
The build will still be failed based on your modifications. Please see following as reference:

A.
root@entos-thunderx2-02:/go/envoyproxy/envoy# git diff
diff --git a/WORKSPACE b/WORKSPACE
index 32547b75..4bac71d3 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -3,7 +3,9 @@ workspace(name = "envoy")
load("//bazel:repositories.bzl", "envoy_dependencies", "GO_VERSION")
load("//bazel:cc_configure.bzl", "cc_configure")

-envoy_dependencies()
+envoy_dependencies(

•   skip_targets=['luajit']
  

+)
cc_configure()

B.
root@entos-thunderx2-02:/go/envoyproxy/envoy# bazel build //source/exe:envoy-static

DEBUG: /root/gopath/src/github.com/envoyproxy/envoy/bazel/repositories.bzl:93:5: External dep build exited with return code: 0
ERROR: /root/gopath/src/github.com/envoyproxy/envoy/source/extensions/filters/common/lua/BUILD:11:1: no such target '//external:luajit': target 'luajit' not declared in package 'external' defined by /root/gopath/src/github.com/envoyproxy/envoy/WORKSPACE and referenced by '//source/extensions/filters/common/lua:lua_lib'
ERROR: Analysis of target '//source/exe:envoy-static' failed; build aborted: Analysis failed
INFO: Elapsed time: 5.403s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (291 packages loaded)

[dnoe]

CircleCI is failing due to some LuaJIT header not found.

[moderation]

@lubinsz In addition to the WORKSPACE modification I compile out unwanted extensions including Lua. My .bazelrc contains build --override_repository=envoy_build_config=~/Library/envoy/build.

~/Library/envoy/build/extensions_build_config.bzl has the following line commented out:

# "envoy.filters.http.lua": "//source/extensions/filters/http/lua:config",

I've been compiling successfully like this without modifications to Bazel since the PGV and rules_go dependencies were updated.

However obviously this doesn't satisfy the scenario where Lua scripting is required for arm64.

[stale]

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[mattklein123]

@lubinsz I don't have any objection to this change (upgrading Lua) but if you want to merge it will need to pass CI. Can you take a look?

[mattklein123]

Marking is waiting.

/wait

[stale]

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[stale]

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[lubinsz]

@mattklein123
Hi mattklein123 ,
Sorry for late.

The reason for the failure is that，CircleCI use the docker image to compile it, not use the command of 'bazel build //source/exe:envoy-static'.
The reason is that, in docker image of 'envoyproxy/envoy-build-ubuntu' , it only contains luajit-2.0.
If you use the command of 'bazel build //source/exe:envoy-static', bazel will download luajit-2.1 automatically. You can use the command of 'bazel build //source/exe:envoy-static' to check it.

So, there are 1 way to solve this problem, we should update the docker image of 'envoyproxy/envoy-build-ubuntu'.

[mattklein123]

@lubinsz you will need to do this in a 2-phase commit. You might need to add luajit-2.1 to the build container, we can submit that, then you can do a 2nd commit to delete luajit-2.0, swap the build container, etc.