Add luajit-2.1 support in source code #5286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likewise, please master latest master here as well. /wait |
Signed-off-by: Bin Lu <[email protected]>
|
@lubinsz you should be able to merge master now, update the build image in https://github.com/envoyproxy/envoy/blob/master/.circleci/config.yml#L7, and also remove the 2.0 build from future images all in the same PR. |
|
Superseded by #5308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add luajit-2.1 support in source code
Luajit 2.0 does not support arm/arm64/ppc64le, while luajit-2.1 supports multi-arch, so I need to add luajit-2.1 in source code.
There is a 2-phase commit to enable envoy for multi-arch.
This is the 2nd commit.
The 1st step is to add luajit-2.1 support to the build container.
Please see phase1: #5285
The discussion is in #4809
Risk Level: Medium
Testing: unit test,integration
Docs Changes: None
Release Notes: None