Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache: add request TypeUrl and ResourceNames to warn log #719

Merged
merged 2 commits into from
Jun 14, 2023
Merged

cache: add request TypeUrl and ResourceNames to warn log #719

merged 2 commits into from
Jun 14, 2023

Conversation

110y
Copy link
Contributor

@110y 110y commented Jun 12, 2023

  • Add request.TypeUrl and request.ResourceNames to the WARN log regarding the resource mismatch for ease of debugging.

jpeach
jpeach approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement.

@jpeach jpeach merged commit cfbc486 into envoyproxy:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@110y @jpeach