Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache: add request TypeUrl and ResourceNames to warn log #719

Merged
merged 2 commits into from
Jun 14, 2023
Merged

cache: add request TypeUrl and ResourceNames to warn log #719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77d3e33
cache: add request TypeUrl and ResourceNames to warn log
110y Jun 12, 2023
c1e6e94
Merge branch 'main' into cache-warn-log
jpeach Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cache/v3/simple.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ func (cache *snapshotCache) respond(ctx context.Context, request *Request, value
// if they do not, then the watch is never responded, and it is expected that envoy makes another request
if len(request.ResourceNames) != 0 && cache.ads {
if err := superset(nameSet(request.ResourceNames), resources); err != nil {
cache.log.Warnf("ADS mode: not responding to request: %v", err)
cache.log.Warnf("ADS mode: not responding to request %s%v: %v", request.TypeUrl, request.ResourceNames, err)
return nil
}
}
Expand Down