Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fallback strategy for RPM packaging #123

Closed
zmotso opened this issue Sep 12, 2024 · 0 comments · Fixed by #124
Closed

Implement fallback strategy for RPM packaging #123

zmotso opened this issue Sep 12, 2024 · 0 comments · Fixed by #124
Assignees
Labels
enhancement New feature or request

Comments

@zmotso
Copy link
Contributor

zmotso commented Sep 12, 2024

Description

  1. The codebase operator should implement a fallback strategy for the languages not supported by RPM. Create a new default template under build/templates/applications/rpm-package. When provisioning a codebase and the specific language implementation doesn't exist, the codebase operator should use default templates to provision assets for the RPM build process.
  2. The codebase operator should check if a Makefile exists in the target repository. If it does, it should create a file named Makefile.kuberocketci to ensure it does not override the existing one.

Acceptance Criteria

  • A default template is created under build/templates/applications/rpm-package/default with two files service.tmpl, spec.tmpl as a fallback strategy for unsupported lang
  • Codebase-operator checks for an existing Makefile and creates Makefile.kuberocketci if Makefile exists.
@zmotso zmotso added the enhancement New feature or request label Sep 12, 2024
@zmotso zmotso self-assigned this Sep 12, 2024
zmotso added a commit that referenced this issue Sep 12, 2024
- Add default template files for RPM if a language is not supported.
- Update operator to create Makefile.kuberocketci if a Makefile already exists.
zmotso added a commit that referenced this issue Sep 12, 2024
- Add default template files for RPM if a language is not supported.
- Update operator to create Makefile.kuberocketci if a Makefile already exists.
SergK pushed a commit that referenced this issue Sep 12, 2024
- Add default template files for RPM if a language is not supported.
- Update operator to create Makefile.kuberocketci if a Makefile already exists.
SergK added a commit that referenced this issue Sep 13, 2024
SergK added a commit that referenced this issue Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant