Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement fallback strategy for RPM packaging #124

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat: Implement fallback strategy for RPM packaging #124

merged 1 commit into from
Sep 12, 2024

Conversation

zmotso
Copy link
Contributor

@zmotso zmotso commented Sep 12, 2024

Pull Request Template

Description

  • Add default template files for RPM if a language is not supported.
  • Update the operator to create Makefile.kuberocketci if a Makefile already exists.

Fixes #123

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit tests
  • Manual testing

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@zmotso zmotso added the enhancement New feature or request label Sep 12, 2024
@zmotso zmotso self-assigned this Sep 12, 2024
@zmotso zmotso requested a review from a team as a code owner September 12, 2024 13:43
- Add default template files for RPM if a language is not supported.
- Update operator to create Makefile.kuberocketci if a Makefile already exists.
@SergK SergK merged commit 433cb68 into master Sep 12, 2024
3 checks passed
@SergK SergK deleted the i/123 branch September 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Implement fallback strategy for RPM packaging
2 participants