#2367 - Ability to move items on the canvas #3286
Conversation
| await bondTwoMonomers(page, peptide3, peptide2); | ||
| await bondTwoMonomers(page, peptide3, peptide4); | ||
|
|
||
| await page.screenshot({ |
There was a problem hiding this comment.
We have function takeEditorScreenshot(page) which takes screenshots of result structure, name it according to test function name and place into folder - you may reuse it here and on 117 line
There was a problem hiding this comment.
I decided to use this function here because I saw screenshots folder and I wanted to put it into the same place.
I replaced the way to do screenshots. Now I use takeEditorScreenshot
| @@ -278,6 +279,13 @@ export abstract class BaseMonomerRenderer extends BaseRenderer { | |||
| } | |||
| } | |||
|
|
|||
| public moveSelection(offset: Vec2) { | |||
| assert(this.rootElement); | |||
| this.monomer.moveRelative(offset); | |||
There was a problem hiding this comment.
Please move this row to DrawingEntitiesManager. Renderers should not change the model. We created DrawingEntitiesManager for this purpose.
| @@ -30,6 +30,13 @@ export class PolymerBondRenderer extends BaseRenderer { | |||
| return this.rootBBox?.height || 0; | |||
| } | |||
|
|
|||
| public moveSelection() { | |||
| assert(this.rootElement); | |||
| this.polymerBond.moveToLinkedMonomers(); | |||
| this.polymerBonds.forEach((drawingEntity) => { | ||
| command.merge( | ||
| this.createDrawingEntityMovingCommand(drawingEntity, offset), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Please mode only selected bonds and those which are connected to selected monomers
There was a problem hiding this comment.
Now it it is better, thank you!
rrodionov91
force-pushed
the
2370-erase-tool
branch
2 times, most recently
from
0716c44
to
19b56df
Compare
rrodionov91
force-pushed
the
2367-Ability-to-move-items-on-the-canvas
branch
from
d8c9da2
to
8059c77
Compare
How the feature works? / How did you fix the issue?
Check list
#1234 – issue name