-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMLR Accessibility Statement Updates #90
HMLR Accessibility Statement Updates #90
Conversation
Updated accessibility statement to reflect the adjusted release dates for both the expected Qonsole update and preparation timestamp alongside the removal of the deadlines for test revisions. Also includes minor copy changes to resolve typos/punctuation issues.
While waiting for the approved translation for the latest update I've updated the copy to improve various characters to be safer to use online.
As provided by the client's translations as requested
Updated to reflect date of latest changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a linter responsible for changing all of the apostrophes?
Yes, however I'm now wondering if it was absolutely necessary, with possible alternatives being using @joescottdave do you know something I don't? 😜 |
Refactored the single quotes, apostrophes, and em-dashes to use the appropriate html entity codes to ensure the presentation of the character was maintained due to differences in language use
Wrapped the appropriate html examples within both a `<code>` wrapper for screen-readability as well as removed erroneous back tick characters
Refactored to contain information inside an `<article>` element instead of duplicating the `<main>` element and ID from the template
I suppose it's ultimately harmless and fairly standard practice at this point to use single quotations in place of apostrophes, just an odd thing for a linter to decide to enforce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR resolves ticket #106 and holds the latest updates for the Accessibility Statements (English and Welsh)