Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/405 info and relationships #433

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Issue/405 info and relationships #433

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f8ecfa
adds messages to tab panel
DanielCouzens Aug 30, 2024
cc0b4e0
Merge branch 'dev' into issue/405-info-and-relationships
DanielCouzens Aug 30, 2024
bc3bd27
adds screenreader message to tabpanel
DanielCouzens Sep 2, 2024
bca0ca6
updates changelog
DanielCouzens Sep 2, 2024
f96dfc4
reverts scss
DanielCouzens Sep 2, 2024
de4b77f
updates html
DanielCouzens Sep 2, 2024
7be0061
updates grammar
DanielCouzens Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## 1.7.5 - 2024-08

- (Dan) Adds message for screenreaders for guidance on how to use tables [Gh-405](https://github.com/epimorphics/ukhpi/issues/405)
- (Dan) Fixed aria-label in compare locations form [GH-416](https://github.com/epimorphics/ukhpi/issues/416)
- (Dan) Adds `aria-label` link attributes on the about page to SPARQL link
[GH-413](https://github.com/epimorphics/ukhpi/issues/413)
Expand Down
5 changes: 4 additions & 1 deletion app/javascript/components/data-view.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class='o-data-view__js-options'>
<data-view-statistics :initial-statistics='availableStatistics' :zoom='false'></data-view-statistics>
</div>
<div class='o-data-view__data-display'>
<div role='tabpanel' aria-describedby='tabpanel-accessibility-message' class='o-data-view__data-display'>
<el-tabs
v-model='activeTab'
@tab-click='onChangeTab'
Expand Down Expand Up @@ -43,6 +43,9 @@
</el-tab-pane>
</el-tabs>
</div>
<p id="tabpanel-accessibility-message" class="u-sr-only" aria-hidden="true">
{{ $t('js.action.accessibility_tabpanel') }}
</p>
</div>

</template>
Expand Down
1 change: 1 addition & 0 deletions config/locales/cy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ cy:
print_table: "argraffu’r tabl hwn"
download_data_as: "Lawrlwytho’r data hwn fel:"
choose_another_location: "Dewiswch leoliad arall"
accessibility_tabpanel: "Mae gan y bwrdd strwythur anarferol. Defnyddiwch yr ail dab yn y tablydd o'r enw Gweler y tabl data am ddata sydd mewn fformat hygyrch."

graph:
no_data: "Mae’n flin gennym, nid yw data %{label} ar gael ar gyfer %{location}. Dewiswch leoliad gwahanol."
Expand Down
1 change: 1 addition & 0 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ en:
print_table: "print this table"
download_data_as: "Download this data as:"
choose_another_location: "Choose another location"
accessibility_tabpanel: "The table has an unusual structure. Please use the second tab in the tablist named See data table for data that is in an accessible format."

graph:
no_data: "Sorry, there is no %{label} data available for %{location}. Please select a different location."
Expand Down