WIP: Fix GuiRenderLigatures for OperatorMono #781
+532
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still needs some code cleanup. I am not aware of any outstanding issues, but I have only done limited testing. |
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
==========================================
+ Coverage 21.17% 21.63% +0.46%
==========================================
Files 73 74 +1
Lines 28151 28285 +134
==========================================
+ Hits 5961 6120 +159
+ Misses 22190 22165 -25
Continue to review full report at Codecov.
|
jgehrig
force-pushed
the
jg-ligaturespacing
branch
from
f887fbb
to
d1f9464
Compare
QString::at does not handle multi-byte Unicode characters. A naive call will only select the first byte from the sequence. Use the entire UTF8 grapheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #771: Operator Mono Font Not Working
The Operator Mono font uses a different encoding scheme than Fira Code. For Fira Code, each character maps has a glyph in QGlyphRun. For Operator Mono, a ligature maps to a single glyph. I did not expect or observe this, so the logic was not tolerant of such an encoding scheme.
Operator Mono also has some monospace positioning irregularities: each character is not exactly the same width. Ligatures may may be slightly larger or smaller than their atomic parts/characters.