Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change robot_id to isar_id and robot_name #141

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Change robot_id to isar_id and robot_name #141

merged 2 commits into from
Mar 16, 2023

Conversation

OleDrange
Copy link
Contributor

No description provided.

@OleDrange OleDrange self-assigned this Feb 13, 2023
@OleDrange OleDrange added improvement Improvement to existing functionality breaking-change A breaking change which introduces changes to the public APIs labels Feb 13, 2023
@OleDrange OleDrange marked this pull request as ready for review February 13, 2023 09:19
aeshub
aeshub approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that tests need to be run again once the ISAR PR has been merged.

@OleDrange OleDrange merged commit 0abf297 into main Mar 16, 2023
@OleDrange OleDrange deleted the isar-id branch March 16, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeshub aeshub aeshub approved these changes

Assignees

@OleDrange OleDrange

Labels
breaking-change A breaking change which introduces changes to the public APIs improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OleDrange @aeshub