Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devnet test failure: mismatched pending subpool size expected=0 got=1 #8615

Open
battlmonstr opened this issue Oct 30, 2023 · 1 comment
Open
Labels

Comments

@battlmonstr
Copy link
Contributor

battlmonstr commented Oct 30, 2023

Step CheckTxPoolContent of devnet scenario "dynamic-tx-node-0" expects that expectedPendingSize is 0, but TxPoolAPIImpl.Content returns 1 pending transaction (it calls api.pool.All() of txpool.proto that returns it).

commit: pr/devnet_fix2 branch

Run:

devnet
--chain=bor-devnet
--datadir=../tgdata/bor-devnet
--bor.localheimdall

Error:

FAILURE mismatched pending subpool size  expected=0 got=1

FAILURE mismatched basefee subpool size
@battlmonstr
Copy link
Contributor Author

This is unexpected, but not critical. Will be demoted to DEBUG here: #8592 . Still worth investigating.

battlmonstr added a commit that referenced this issue Nov 1, 2023
* fix "genesis hash does not match" when dev nodes connect  
The "dev" nodes need to have the same --miner.etherbase in order to
generate the same genesis ExtraData by DeveloperGenesisBlock(). Override
DevnetEtherbase global var that's used if --miner.etherbase is not
passed. (for NonBlockProducer case)

* fix missing private key for the hardcoded DevnetEtherbase  
Fixes panic if SigKey is not found. Bor non-producers will use a default
`DevnetEtherbase` while Dev nodes modify it. Save hardcoded
DevnetEtherbase/DevnetSignPrivateKey into accounts so that SigKey can
recover it.

* refactor devnet.node to contain Node config  
This avoids interface{} type casts and fixes an error with
Heimdall.validatorSet == nil

* add connection retries to rpcCall and Subscribe of requestGenerator  
Fixes "connection refused" errors due to node not ready to handle early
RPC requests.

* fix deadlock in Heimdall.NodeStarted

* fix GetBlockByNumber
Fixes "cannot unmarshal string into Go struct field body.transactions of
type jsonrpc.RPCTransaction"

* demote "no of blocks on childchain is less than confirmations
required" to Info (#8626)

* demote "mismatched pending subpool size" to Debug (#8615)

* revert wiggle testing code
@mh0lt mh0lt added the imp3 Low importance label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants