Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devnet test error: L2 header processing - childchain has less confirmations than required #8626

Closed
battlmonstr opened this issue Oct 30, 2023 · 1 comment
Closed

devnet test error: L2 header processing - childchain has less confirmations than required #8626

battlmonstr opened this issue Oct 30, 2023 · 1 comment
Assignees
@battlmonstr
Labels
devnet polygon

Comments

@battlmonstr
Copy link
Contributor

battlmonstr commented Oct 30, 2023 •
edited
Loading

Step AwaitBlocks of devnet scenario "dynamic-tx-node-0" produces an error in Heimdall.handleChildHeader(),
because header.Number (3) <= ChildChainTxConfirmations (10).

This also happens in "state-sync" scenario on many steps.

commit: pr/devnet_fix2 branch

Run:

devnet
--chain=bor-devnet
--datadir=../tgdata/bor-devnet
--bor.localheimdall

Error:

no of blocks on childchain is less than confirmations required childChainBlocks=3 confirmationsRequired=10
L2 header processing failed              header=3 err="no of blocks on childchain is less than confirmations required"
@battlmonstr battlmonstr changed the title devnet test error: L2 header processing - childchain is less than confirmations required devnet test error: L2 header processing - childchain has less confirmations than required Oct 30, 2023
@battlmonstr battlmonstr mentioned this issue Oct 31, 2023
Merged
@battlmonstr battlmonstr self-assigned this Oct 31, 2023
@battlmonstr
Copy link
Contributor Author

This is expected in the beginning, will be changed to Info here: #8592

battlmonstr added a commit that referenced this issue Oct 31, 2023
@battlmonstr
demote "no of blocks on childchain is less than confirmations require…
b080a71 
…d" to Info (#8626)
battlmonstr added a commit that referenced this issue Nov 1, 2023
@battlmonstr
devnet: configuration fixes (#8592)
3698e7f 
* fix "genesis hash does not match" when dev nodes connect  
The "dev" nodes need to have the same --miner.etherbase in order to
generate the same genesis ExtraData by DeveloperGenesisBlock(). Override
DevnetEtherbase global var that's used if --miner.etherbase is not
passed. (for NonBlockProducer case)

* fix missing private key for the hardcoded DevnetEtherbase  
Fixes panic if SigKey is not found. Bor non-producers will use a default
`DevnetEtherbase` while Dev nodes modify it. Save hardcoded
DevnetEtherbase/DevnetSignPrivateKey into accounts so that SigKey can
recover it.

* refactor devnet.node to contain Node config  
This avoids interface{} type casts and fixes an error with
Heimdall.validatorSet == nil

* add connection retries to rpcCall and Subscribe of requestGenerator  
Fixes "connection refused" errors due to node not ready to handle early
RPC requests.

* fix deadlock in Heimdall.NodeStarted

* fix GetBlockByNumber
Fixes "cannot unmarshal string into Go struct field body.transactions of
type jsonrpc.RPCTransaction"

* demote "no of blocks on childchain is less than confirmations
required" to Info (#8626)

* demote "mismatched pending subpool size" to Debug (#8615)

* revert wiggle testing code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@battlmonstr battlmonstr

Labels
devnet polygon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@battlmonstr