Extend Unicode terminal parsing #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
reviewed
Jun 15, 2023
Comment on lines
+131
to
133
| case CodePoint(cp, desc) => | ||
| app >> "<U+" >> cp >> (if (desc == "") "" else " " + desc) >> ">" | ||
| case CodePointAbbr(abbr) => app >> "<" >> abbr >> ">" |
There was a problem hiding this comment.
Isn't this still missing support for bare code point nonterminals described in the second bullet point at grammarkdown Character Literals and Ranges (e.g., U+00A0 and U+1D306)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #147, I extended the Unicode terminal parsing algorithm by adding the
CodePointcase for symbols in the spec.Now, we support the following terminal symbols as well according to The Unicode Standard, Version 15.0.0, Appendix A, Notational Conventions and rbuckton/grammarkdown#91: