Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate mod_privacy to mongoose_backend #3347

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Migrate mod_privacy to mongoose_backend #3347

merged 2 commits into from
Oct 20, 2021

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

vkatsuba
vkatsuba reviewed Oct 20, 2021
View reviewed changes
src/privacy/mod_privacy_backend.erl
Default :: mod_privacy:list_name(),
Items :: [mod_privacy:list_item()],
Reason :: not_found | term().

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line here, but can be fixed in other PR.

@codecov
Copy link

codecov bot commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #3347 (36c3539) into without-dynamic-backend-modules (01fb11a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 36c3539 differs from pull request most recent head e7a322c. Consider uploading reports for the commit e7a322c to get more accurate results
Impacted file tree graph

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3347      +/-   ##
===================================================================
- Coverage                            80.73%   80.70%   -0.03%     
===================================================================
  Files                                  401      402       +1     
  Lines                                32496    32508      +12     
===================================================================
  Hits                                 26235    26235              
- Misses                                6261     6273      +12
Impacted Files Coverage Δ
src/event_pusher/mod_event_pusher.erl 87.50% <ø> (+22.50%) ⬆️
src/event_pusher/mod_event_pusher_push_mnesia.erl 90.62% <ø> (ø)
src/event_pusher/mod_event_pusher_push_plugin.erl 100.00% <ø> (ø)
src/event_pusher/mod_event_pusher_push_rdbms.erl 97.43% <ø> (ø)
src/mod_last.erl 86.56% <ø> (ø)
src/mod_last_backend.erl 100.00% <ø> (ø)
src/event_pusher/mod_event_pusher_push.erl 94.73% <100.00%> (ø)
src/event_pusher/mod_event_pusher_push_backend.erl 100.00% <100.00%> (ø)
...t_pusher/mod_event_pusher_push_plugin_defaults.erl 93.10% <100.00%> (ø)
src/mod_roster_mnesia.erl 72.72% <0.00%> (-21.22%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ec4b1...e7a322c. Read the comment docs.

@mongoose-im
Copy link
Collaborator

small_tests_24 / small_tests / 0f645ff
Reports root / small

vkatsuba
vkatsuba reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@vkatsuba vkatsuba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xref:

===> src/event_pusher/mod_event_pusher_push_backend.erl:41: Warning: mod_event_pusher_push_backend:init/2 calls undefined function mongoose_backend:init_per_host_type/3 (Xref)
src/mongoose_backend.erl: Warning: mongoose_backend:init_per_host_type/3 is undefined function (Xref)

https://github.com/esl/MongooseIM/blob/without-dynamic-backend-modules/src/event_pusher/mod_event_pusher_push_backend.erl#L43

https://github.com/esl/MongooseIM/blob/without-dynamic-backend-modules/src/mongoose_backend.erl#L4

@NelsonVides
Copy link
Collaborator Author

Xref:

===> src/event_pusher/mod_event_pusher_push_backend.erl:41: Warning: mod_event_pusher_push_backend:init/2 calls undefined function mongoose_backend:init_per_host_type/3 (Xref)
src/mongoose_backend.erl: Warning: mongoose_backend:init_per_host_type/3 is undefined function (Xref)

https://github.com/esl/MongooseIM/blob/without-dynamic-backend-modules/src/event_pusher/mod_event_pusher_push_backend.erl#L43

I know, that was actually failing in the parent branch, fix coming here #3348

@vkatsuba
Copy link
Contributor

I know, that was actually failing in the parent branch, fix coming here #3348

But why CI was passed in #3340 ...

@NelsonVides
Copy link
Collaborator Author

I know, that was actually failing in the parent branch, fix coming here #3348

But why CI was passed in #3340 ...

Very good question 🤷🏽‍♂️

@gustawlippa
Copy link
Contributor

There were two PRs opened, #3340 ran CI, passed, another PR (#3339) made changes to the API, the tests for it passed and it was merged first. Then the first one was merged with incorrect call but with green CI. A fix is merged already to the feature branch, sorry for the confusion.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 20, 2021 •
edited
Loading

small_tests_24 / small_tests / e7a322c
Reports root / small

internal_mnesia_24 / internal_mnesia / e7a322c
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / e7a322c
Reports root / small

ldap_mnesia_24 / ldap_mnesia / e7a322c
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / e7a322c
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / e7a322c
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / e7a322c
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e7a322c
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / e7a322c
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / e7a322c
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / e7a322c
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / e7a322c
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / e7a322c
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / e7a322c
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / e7a322c
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

@vkatsuba vkatsuba merged commit 9411c90 into without-dynamic-backend-modules Oct 20, 2021
@vkatsuba vkatsuba deleted the wdbm/privacy branch October 20, 2021 14:02
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkatsuba vkatsuba vkatsuba approved these changes

@gustawlippa gustawlippa Awaiting requested review from gustawlippa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@NelsonVides @mongoose-im @vkatsuba @gustawlippa @Premwoik