Fix function call #3348
Merged
Fix function call #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustawlippa
approved these changes
Oct 20, 2021
|
@gustawlippa before merge something, need wait for finishing CI... even if these are obvious changes ... |
|
small_tests_24 / small_tests / 36c3539 internal_mnesia_24 / internal_mnesia / 36c3539 small_tests_23 / small_tests / 36c3539 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 36c3539 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 36c3539 ldap_mnesia_24 / ldap_mnesia / 36c3539 amp_big_SUITE:basic:notify_deliver_to_online_user_recipient_privacy_test{error,
{test_case_failed,
{has_stanzas_but_shouldnt,
{client,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_87.19949@localhost/res1">>,
escalus_tcp,<0.2868.0>,
[{event_manager,<0.2520.0>},
{server,<<"localhost">>},
{username,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_87.19949">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.2520.0>},
{server,<<"localhost">>},
{username,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_87.19949">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_87.19949">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_notify_deliver_to_online_user_recipient_privacy_test_87.19949">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"bb5301bc3cb80ace">>}]},
[{xmlel,<<"stream:error">>,[],
[{xmlel,<<"conflict">>,
[{<<"xmlns">>,
<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[]},
{xmlel,<<"text">>,
[{<<"xml:lang">>,<<"en">>},
{<<"xmlns">>,
<<"urn:ietf:params:xml:ns...dynamic_domains_mysql_redis_24 / mysql_redis / 36c3539 ldap_mnesia_23 / ldap_mnesia / 36c3539 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 36c3539 inbox_SUITE:one_to_one:user_has_only_unread_messages_or_only_read{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bOb_user_has_only_unread_messages_or_only_read_65.436773@domain.example.com/res1">>,
escalus_tcp,<0.16435.0>,
[{event_manager,<0.16327.0>},
{server,<<"domain.example.com">>},
{username,
<<"bOb_user_has_only_unread_messages_or_only_read_65.436773">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16327.0>},
{server,<<"domain.example.com">>},
{username,
<<"bOb_user_has_only_unread_messages_or_only_read_65.436773">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"bOb_user_has_only_unread_messages_or_only_read_65.436773">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"bOb_user_has_only_unread_messages_or_only_read_65.436773">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"bf61ef614986fdf1">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,get_inbox,3,
[{file,"/home/circleci/a...inbox_SUITE:muclight:advanced_groupchat_stored_in_all_inbox{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_advanced_groupchat_stored_in_all_inbox_72.597295@domain.example.com/res1">>,
escalus_tcp,<0.16654.0>,
[{event_manager,<0.16643.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_advanced_groupchat_stored_in_all_inbox_72.597295">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16643.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_advanced_groupchat_stored_in_all_inbox_72.597295">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_advanced_groupchat_stored_in_all_inbox_72.597295">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_advanced_groupchat_stored_in_all_inbox_72.597295">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"e5061daeb5f824eb">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{muc_light_helper,given_muc_light_room,3,
[{file,"/home/circl...inbox_SUITE:muclight:groupchat_reset_stanza_resets_inbox{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_groupchat_reset_stanza_resets_inbox_72.589048@domain.example.com/res1">>,
escalus_tcp,<0.16652.0>,
[{event_manager,<0.16592.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_groupchat_reset_stanza_resets_inbox_72.589048">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16592.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_groupchat_reset_stanza_resets_inbox_72.589048">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_groupchat_reset_stanza_resets_inbox_72.589048">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_groupchat_reset_stanza_resets_inbox_72.589048">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"a571e323bc7cda67">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{muc_light_helper,given_muc_light_room,3,
[{file,"/home/circleci/app/big_tes...inbox_SUITE:muclight:non_reset_marker_should_not_affect_muclight_inbox{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_72.597978@domain.example.com/res1">>,
escalus_tcp,<0.16649.0>,
[{event_manager,<0.16636.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_72.597978">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16636.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_72.597978">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_72.597978">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_72.597978">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"898108645ef2dd09">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{muc_light_he...inbox_SUITE:muclight:create_groupchat{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.16663.0>,
[{event_manager,<0.16648.0>},
{server,<<"domain.example.com">>},
{username,<<"bOb_create_groupchat_72.597477">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16648.0>},
{server,<<"domain.example.com">>},
{username,<<"bOb_create_groupchat_72.597477">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bOb_create_groupchat_72.597477">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_create_groupchat_72.597477">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"8a79c48774507945">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{muc_helper,'-foreach_recipient/2-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/muc_helper.erl"},
{line,45}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{muc_light_helper,verify_aff_bcast,3,
[{fi...inbox_SUITE:muclight:groupchat_markers_one_reset{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.16656.0>,
[{event_manager,<0.16627.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_groupchat_markers_one_reset_72.597848">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16627.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_groupchat_markers_one_reset_72.597848">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_groupchat_markers_one_reset_72.597848">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_groupchat_markers_one_reset_72.597848">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"f73c9974eea7546d">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{muc_light_helper,given_muc_light_room,3,
[{file,"/home/circleci/app/big_tests/tests/muc_light_helper.erl"},
...inbox_SUITE:muclight:leave_and_remove_conversation{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.16651.0>,
[{event_manager,<0.16620.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_leave_and_remove_conversation_72.597742">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16620.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_leave_and_remove_conversation_72.597742">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_leave_and_remove_conversation_72.597742">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_leave_and_remove_conversation_72.597742">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"0df8efc75d328b53">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{muc_light_helper,given_muc_light_room,3,
[{file,"/home/circleci/app/big_tests/tests/muc_light_helper.erl"...inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_simple_groupchat_stored_in_all_inbox_72.590777@domain.example.com/res1">>,
escalus_tcp,<0.16657.0>,
[{event_manager,<0.16608.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_simple_groupchat_stored_in_all_inbox_72.590777">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16608.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_simple_groupchat_stored_in_all_inbox_72.590777">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_simple_groupchat_stored_in_all_inbox_72.590777">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_simple_groupchat_stored_in_all_inbox_72.590777">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"2dea15f273060ce8">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{muc_light_helper,given_muc_light_room,3,
[{file,"/home/circleci/app/bi...inbox_SUITE:muclight:groupchat_markers_one_reset_room_created{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_groupchat_markers_one_reset_room_created_72.589693@domain.example.com/res1">>,
escalus_tcp,<0.16653.0>,
[{event_manager,<0.16601.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_groupchat_markers_one_reset_room_created_72.589693">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16601.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_groupchat_markers_one_reset_room_created_72.589693">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_groupchat_markers_one_reset_room_created_72.589693">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_groupchat_markers_one_reset_room_created_72.589693">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"6cc7c73af98d7896">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{muc_helper,'-foreach_recipient/2-fun-0-',2,
[{file...inbox_SUITE:muclight:groupchat_markers_all_reset_room_created{error,{badarg,[{erlang,binary_to_integer,
[undefined],
[{error_info,#{module => erl_erts_errors}}]},
{inbox_helper,get_result_el,2,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,236}]},
{inbox_helper,'-check_result/2-fun-0-',3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,241}]},
{maps,filter_1,2,[{file,"maps.erl"},{line,318}]},
{maps,filter,2,[{file,"maps.erl"},{line,309}]},
{inbox_helper,get_inbox,3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,222}]},
{inbox_helper,check_inbox,4,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,167}]},
{inbox_helper,create_room_and_check_inbox,3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,523}]}]}}pgsql_mnesia_24 / pgsql_mnesia / 36c3539 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 36c3539 pgsql_mnesia_23 / pgsql_mnesia / 36c3539 mssql_mnesia_24 / odbc_mssql_mnesia / 36c3539 mysql_redis_24 / mysql_redis / 36c3539 mam_SUITE:rdbms_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}riak_mnesia_24 / riak_mnesia / 36c3539 |
By fault as well, I suggested to merge promptly. We just waited for xref and dialyzer to be green. |
Clear. |
|
I merged it so quickly so that by chance people won't branch out from the feature branch with incorrect code and search for bugs in their changes. Sure we would not do that normally, but keep in mind this is all WIP. |
If developer didn't change code from where provided error in
Following this logic - it no make sense also to create PR's at all then for current branch till time when this branch will finished and ready for PR, but this is wrong approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function with arity 3 was not actually defined :)