Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OTP version to 25.0.1 #3683

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Bump OTP version to 25.0.1 #3683

merged 4 commits into from
Jun 13, 2022

Conversation

chrzaszcz
Copy link
Member

Resolves missing Erlang 25.0 for the debian stretch package.

Paweł Chrząszcz and others added 3 commits June 13, 2022 13:43
Bump OTP version to 25.0.1
6b01e2a 
Resolves missing Erlang 25.0 for debian stretch package
@chrzaszcz
Enable dialyzer for both OTP 24 and OTP 25
d443b0b
Make the request_id type consistent in the code
16f7632 
gen_server:request_id is not exported in OTP 24,
but let's keep the changes limited for now.
@codecov
Copy link

codecov bot commented Jun 13, 2022 •
edited
Loading

Codecov Report

Merging #3683 (5e37f07) into master (58ae60a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
+ Coverage   81.14%   81.15%   +0.01%     
==========================================
  Files         433      433              
  Lines       31882    31882              
==========================================
+ Hits        25870    25874       +4     
+ Misses       6012     6008       -4
Impacted Files Coverage Δ
src/async_pools/mongoose_aggregator_worker.erl 61.70% <ø> (ø)
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/ejabberd_c2s.erl 89.23% <0.00%> (-0.15%) ⬇️
src/mod_roster.erl 79.18% <0.00%> (+0.47%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 88.39% <0.00%> (+1.78%) ⬆️
src/pubsub/node_pep.erl 79.62% <0.00%> (+1.85%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 68.88% <0.00%> (+2.22%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 84.61% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ae60a...5e37f07. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 13, 2022 •
edited
Loading

small_tests_24 / small_tests / 6b01e2a
Reports root / small

small_tests_25 / small_tests / 6b01e2a
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6b01e2a
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 6b01e2a
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 6b01e2a
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 6b01e2a
Reports root/ big
OK: 2808 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6b01e2a
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 6b01e2a
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6b01e2a
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 6b01e2a
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 6b01e2a
Reports root/ big
OK: 1731 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 6b01e2a
Reports root/ big
OK: 3216 / Failed: 2 / User-skipped: 102 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1897@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1897@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"ndL12oPV+b0Xu67MnRbiHw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1909@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1909@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"+e8CJVhPlKBaPZMh676Jlg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6b01e2a
Reports root/ big
OK: 1876 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 6b01e2a
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 6b01e2a
Reports root/ big
OK: 3211 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4383}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4124}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4120}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6b01e2a
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 6b01e2a
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 6b01e2a
Reports root/ big
OK: 3216 / Failed: 2 / User-skipped: 102 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,{{badmatch,false},
    [{pubsub_tools,check_notification,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,509}]},
     {pubsub_tools,receive_notification,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,505}]},
     {pubsub_tools,receive_item_notification,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,303}]},
     {pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
          [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
           {line,373}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pep_SUITE:pep_tests:authorize_access_model 
{error,{{badmatch,false},
    [{pubsub_tools,check_notification,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,509}]},
     {pubsub_tools,receive_notification,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,505}]},
     {pubsub_tools,receive_item_notification,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,303}]},
     {pep_SUITE,'-authorize_access_model/1-fun-0-',2,
          [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
           {line,356}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 6b01e2a
Reports root/ big
OK: 3194 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review June 13, 2022 12:53
@arcusfelis
Merge pull request #3680 from esl/dialyzer-in-otp24
5e37f07 
Enable dialyzer for both OTP 24 and OTP 25
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 13, 2022 •
edited
Loading

small_tests_24 / small_tests / 5e37f07
Reports root / small

small_tests_25 / small_tests / 5e37f07
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5e37f07
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 5e37f07
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 5e37f07
Reports root/ big
OK: 2808 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5e37f07
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 5e37f07
Reports root/ big
OK: 1526 / Failed: 1 / User-skipped: 401 / Auto-skipped: 0

pubsub_SUITE:tree+basic:publish_with_max_items_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_publish_with_max_items_test_1067@localhost/res1">>,
          escalus_tcp,<0.3247.1>,
          [{event_manager,<0.3182.1>},
           {server,<<"localhost">>},
           {username,<<"bOb_publish_with_max_items_test_1067">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.3182.1>},
            {server,<<"localhost">>},
            {username,<<"bOb_publish_with_max_items_test_1067">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"bob_publish_with_max_items_test_1067">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"bOb_publish_with_max_items_test_1067">>},
           {server,<<"localhost">>},
           {password,<<"makrolika">>},
           {stream_id,<<"b98fb1a64b79ab80">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_notification,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,504}]},
     {pubsub_tools,receive_item_notification,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,303}]},
     {pubsub_SUI...

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5e37f07
Reports root/ big
OK: 2837 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4383}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4124}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4120}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / 5e37f07
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 5e37f07
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 5e37f07
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5e37f07
Reports root/ big
OK: 1876 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 5e37f07
Reports root/ big
OK: 3210 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0

vcard_SUITE:ro_full:retrieve_own_card 
{error,{test_case_failed,"Expected <<\"alice\">> got undefined\n"}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 5e37f07
Reports root/ big
OK: 3221 / Failed: 2 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2019@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2019@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"XqatwdPxSWmjoAGHo0tPbw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pep_SUITE:pep_tests:authorize_access_model 
{error,{{badmatch,false},
    [{pubsub_tools,check_notification,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,509}]},
     {pubsub_tools,receive_notification,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,505}]},
     {pubsub_tools,receive_item_notification,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,303}]},
     {pep_SUITE,'-authorize_access_model/1-fun-0-',2,
          [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
           {line,356}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / 5e37f07
Reports root/ big
OK: 1731 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 5e37f07
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

arcusfelis
arcusfelis approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@arcusfelis arcusfelis merged commit 330bd81 into master Jun 13, 2022
@arcusfelis arcusfelis deleted the otp-25.0.1 branch June 13, 2022 14:24
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcusfelis arcusfelis arcusfelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chrzaszcz @mongoose-im @arcusfelis