Telemetry curation #155
Closed
Telemetry curation #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
telemetry_curation
branch
3 times, most recently
from
eb98f0f
to
5ecee37
Compare
NelsonVides
force-pushed
the
telemetry_curation
branch
2 times, most recently
from
8375136
to
bcc140d
Compare
NelsonVides
force-pushed
the
telemetry_curation
branch
from
bcc140d
to
7d82f56
Compare
NelsonVides
force-pushed
the
telemetry_curation
branch
from
7d82f56
to
f3336e4
Compare
NelsonVides
force-pushed
the
telemetry_curation
branch
from
f3336e4
to
bb2a0b4
Compare
This was referenced Dec 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to want timestamps for all these telemetry events, so that metrics collectors can aggregate and draw plots based on time.
I also want an event for scenario start and stop which will mimic telemetry's
spanmechanism, but which here it is done in this way because the controller separately calls the beginning and the end of the scenario andspanwouldn't fit into this mechanism.I also don't want logs to be raised by
amoc. Logging might be desired to work differently, so instead of logs I'll also raise here telemetry events for internals, and in the subscribers I'll decide if I want to log something or not and how.