-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry/rework logs #163
Conversation
6568048
to
dd2108d
Compare
aef47e2
to
4379927
Compare
4379927
to
7933fc0
Compare
57620b4
to
b565018
Compare
7933fc0
to
cf8e5a7
Compare
cf8e5a7
to
e593cc0
Compare
b834956
to
c494c65
Compare
e593cc0
to
b652d5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR requires rework.
b652d5f
to
68fe3c9
Compare
68fe3c9
to
dec6efc
Compare
dec6efc
to
49ac503
Compare
it's just a general comment, and doesn't have to be implemented in this PR. |
If it's not needed now I'll create a Jira ticket and we can discuss it any other time in the future 🙃 All other comments applied. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 33.23% 33.23%
=======================================
Files 23 23
Lines 975 981 +6
=======================================
+ Hits 324 326 +2
- Misses 651 655 +4 ☔ View full report in Codecov by Sentry. |
I also don't want logs to be raised by amoc. Logging might be desired to work differently, so instead of logs I'll also raise here telemetry events for internals, and in the subscribers I'll decide if I want to log something or not and how.
Split from #155 , uses #162