Type-erase timers by default #2136
Draft
+120
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liebman
reviewed
Sep 11, 2024
bugadani
force-pushed
the
timer
branch
2 times, most recently
from
244114f
to
52b650d
Compare
bugadani
force-pushed
the
timer
branch
2 times, most recently
from
300f88d
to
08bd61e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of an experimental PR, trying to give timers the same treatment as GPIOs. Unfortunately due to async timers, this isn't exactly the same changeset. Internal code doesn't use this, and one test regressed to use
new_typedbecause not every Timer can currently be turned into an AnyTimer, but I'm still interested whether this idea is worth pursuing outside of GPIO-land, too.