Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RTCIO pullup, pulldown and hold control for Xtensa MCUs #684

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jul 25, 2023

No examples yet. The goal is to eventually implement GPIO wakeup sources which can configure pullups/pulldowns, and I expect an example to cover this functionality at that point.

Examples are part of #690

@bugadani
Copy link
Contributor Author

bugadani commented Aug 8, 2023

@jessebraham I don't know if I should ping you or not, but I have to ask if this PR is in the queue or got lost due to me drafting it back-and-forth multiple times 😅

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit a2ae6f3 into esp-rs:main Aug 14, 2023
16 checks passed
@bugadani bugadani deleted the pull branch August 14, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants