S3: GPIO wakeup source with RTC_IO pins #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't love it, but the API is much nicer without the tons of |
bugadani
force-pushed
the
s3_rtcio
branch
2 times, most recently
from
30c5002
to
2ded36e
Compare
bugadani
force-pushed
the
s3_rtcio
branch
2 times, most recently
from
b536530
to
3705a7b
Compare
bugadani
changed the title
Merged
bugadani
force-pushed
the
s3_rtcio
branch
4 times, most recently
from
b60f15d
to
d3bb732
Compare
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Remove unnecessary Pin bounds * S3: Add RTC_IO wakeup source * Add s3 example * Add changelog entry --------- Co-authored-by: Jesse Braham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo fmtwas run.CHANGELOG.mdin the proper section.Nice to have
RTC_IO wakeup is using the GPIO wakeup source, but restricted to RTC_IO pins. Compared to esp-idf's idea of GPIO wakeup (which this PR doesn't prevent implementing, hence the different naming), it allows waking from deep sleep, as noted by the TRM.
cc #375