Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLD option for all Xtensa chips #861

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Add LLD option for all Xtensa chips #861

merged 3 commits into from
Oct 25, 2023

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Oct 20, 2023

Although not yet recommended, from 1.74 it will be possible to link all esp-hal examples (esp-wifi still running into some issues). This PR makes the required changes to the linker scripts for LLD support, as well as adding the option in .cargo/config.toml.

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MabezDev MabezDev merged commit 6eca968 into esp-rs:main Oct 25, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants