Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the USB Serial JTAG watchdog workaround now that we use the stub #345

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

jessebraham
Copy link
Member

No description provided.

@jessebraham jessebraham merged commit 1c054e8 into esp-rs:main Jan 17, 2023
@jessebraham jessebraham deleted the fixes/cleanup branch January 17, 2023 19:19
@MabezDev
Copy link
Member

I think we also need to update the stubs from espressif/esptool@32e8014, I did report this last year but it only got fixed in the stub a few days ago.

@MabezDev
Copy link
Member

Actually, we probably shouldn't have removed this but instead executed if use_stub is false, sorry that comment was actually a bit misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants