Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring Wire.h buffer size #8388

Closed
wants to merge 1 commit into from
Closed

Conversation

flaviut
Copy link
Contributor

@flaviut flaviut commented Nov 27, 2021

This is needed since in some applications, we need much much larger buffers.

See emporia-vue-local/emporia-vue2-reversing#1 (comment)

This is needed since in some applications, we need much much larger buffers.

See emporia-vue-local/emporia-vue2-reversing#1 (comment)
@flaviut
Copy link
Contributor Author

flaviut commented Nov 27, 2021

After further investigation prompted by @Maelstrom96's comments elsewhere, this isn't sufficient to allow for the 284 byte payloads we need to handle.

We'd also need #ifs to make sure that the various types aren't uint8_t, but are promoted to uint16_t when the size of the payload is increased. I'd be happy to do that work, if the maintainers would chime in on if that'd be an acceptable solution, or if it'd be better to fork the Wire library.

@flaviut
Copy link
Contributor Author

flaviut commented Nov 27, 2021

Whoops! I shouldn't be programming before fully waking up! I'm actually looking to do this on the ESP32, not ESP8266.

I'd be happy to port any changes here too, please re-open this if you'd like me to do that.

@flaviut flaviut closed this Nov 27, 2021
@mcspr
Copy link
Collaborator

mcspr commented Nov 27, 2021

See #8388 espressif/arduino-esp32#5172
Might be a good idea to share the name of the setting

@d-a-v
Copy link
Collaborator

d-a-v commented Nov 27, 2021

Using int16 or even int32 sometimes generate less code / is faster than when using int8, on this architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants