Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding custom buffer_length using I2C_BUFFER_LENGTH #8390

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Adding custom buffer_length using I2C_BUFFER_LENGTH #8390

merged 4 commits into from
Dec 1, 2021

Conversation

Maelstrom96
Copy link
Contributor

New PR that expands on #8388.

Changed it so it's the same setting name (I2C_BUFFER_LENGTH) on both ESP8266 and ESP32 Wire library.

d-a-v
d-a-v approved these changes Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.
As mentioned in the other closed PR, rx/txBufferIndex and rx/txBufferLength should be made into 16 or 32 bits. I guess this will be for another PR.

@d-a-v d-a-v mentioned this pull request Nov 28, 2021
Closed
@d-a-v
Copy link
Collaborator

d-a-v commented Nov 28, 2021

If you are running with linux or wsl2, there's the tests/restyle.sh script that will do the reformatting for you.

@Maelstrom96
Copy link
Contributor Author

The style should match what it's expecting now - Also merged changes from master.

@Maelstrom96
Copy link
Contributor Author

Missing anything in order for this to get merged?

@d-a-v d-a-v merged commit 0f231b1 into esp8266:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maelstrom96 @d-a-v