Partition Table Editor UI (VSC-439) #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master from espressif/vscode-esp-idf-extension
Merge commit
Master merge
merge from GH master
Sync Merge
Sync with master
Github Master sync
* initial esp-adf support * fix images in examples html src * choose framework before loading examples * fix some images in markdown html * fix svg images * mv types marked to dev deps * add esp-mdf and examples * set MDF to MDF_PATH env variable
Bumps [bl](https://github.com/rvagg/bl) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](rvagg/bl@v4.0.2...v4.0.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Pull request has been marked as |
|
Pull request has been marked as |
|
@brianignacio5 are you implementing the NVS Editor based on this PR? If so we can review and merge it first. |
|
Sure thing, I originally wanted to reuse the most of the code (just picking some parts of the code), maybe in future we can refactor to have common components between different webviews. Will review this PR today. |
brianignacio5
previously requested changes
Dec 18, 2020
Merged
brianignacio5
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UI for editing and flashing Partition Table
Tasks
i18nbuild & flashbuttonScreenshots