Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some superfluous executable bits #2242

Merged
merged 2 commits into from
Sep 10, 2018

Conversation

junghans
Copy link
Member

@junghans junghans commented Sep 8, 2018

chmod -x AUTHORS ChangeLog COPYING INSTALL NEWS README

There are a couple more in the source, these are the ones rpmlint is complaining about.

`chmod -x AUTHORS ChangeLog COPYING INSTALL NEWS README`
@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #2242 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2242    +/-   ##
=======================================
+ Coverage      71%     71%   +<1%     
=======================================
  Files         377     377            
  Lines       18941   18941            
=======================================
+ Hits        13560   13580    +20     
+ Misses       5381    5361    -20
Impacted Files Coverage Δ
src/core/layered.cpp 79% <0%> (ø) ⬆️
src/core/domain_decomposition.cpp 91% <0%> (+3%) ⬆️
src/core/lattice.cpp 89% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db1d71...83ef280. Read the comment docs.

@hmenke
Copy link
Member

hmenke commented Sep 8, 2018

There are a couple more in the source

I think its okay to just remove all of them (except the ones on actual executables of course).

@hmenke
Copy link
Member

hmenke commented Sep 8, 2018

I have now removed the executable bit from all files which do not start with a shebang #! and added a shebang in two places where it seems appropriate that the file remains executable.

Copy link
Member Author

@junghans junghans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KaiSzuttor KaiSzuttor merged commit d27c095 into espressomd:python Sep 10, 2018
@junghans junghans deleted the remove_exe_bit branch September 10, 2018 12:55
@RudolfWeeber RudolfWeeber added this to the Espresso 4.0.1 milestone Oct 15, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Oct 15, 2018
Remove some superfluous executable bits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants