Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ekin immutable and disable ekin checkpointing #4327

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Make ekin immutable and disable ekin checkpointing #4327

merged 3 commits into from
Aug 12, 2021

Conversation

christophlohrmann
Copy link
Contributor

@christophlohrmann christophlohrmann commented Aug 12, 2021 •
edited by jngrad
Loading

Closes #4210

Description of changes:

  • Calling an ekin value setter after the method is initialized will throw an error
  • This does not play nice with ekin checkpointing, so checkpointing gets disabled

@jngrad jngrad self-requested a review August 12, 2021 08:04
@jngrad jngrad added this to the Espresso 4.2 milestone Aug 12, 2021
@jngrad jngrad changed the title ekin immutable Make ekin immutable and disable ekin checkpointing Aug 12, 2021
jngrad
jngrad approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jngrad jngrad added the automerge Merge with kodiak label Aug 12, 2021
@kodiakhq kodiakhq bot merged commit 6b9555c into espressomd:python Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Core
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

EK parameter changes after activation do not apply
2 participants
@christophlohrmann @jngrad