Skip to content

Commit

Permalink
Change an to a in ERC 1271, as it precedes signed (#6951)
Browse files Browse the repository at this point in the history
Change `an` to `a` in ERC 1271, as it precedes `signed`. I believe this was just a typo.

I also noticed the clause:

> considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract

And think "signers" may be a typo, or I may just be misinterpreting the sentence.
  • Loading branch information
flanagansteve authored May 4, 2023
1 parent 2d4b68d commit 0ce65ae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion EIPS/eip-1271.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ This function should be implemented by contracts which desire to sign messages (
## Rationale
We believe the name of the proposed function to be appropriate considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract. Hence, an signed action message is only valid when the signer is authorized to perform a given action on the behalf of a smart wallet.
We believe the name of the proposed function to be appropriate considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract. Hence, a signed action message is only valid when the signer is authorized to perform a given action on the behalf of a smart wallet.
Two arguments are provided for simplicity of separating the hash signed from the signature. A bytes32 hash is used instead of the unhashed message for simplicy, since contracts could expect a certain hashing function that is not standard, such as with [EIP-712](./eip-712.md).
Expand Down

0 comments on commit 0ce65ae

Please sign in to comment.