Update EIP-1271: Change an to a in ERC 1271, as it precedes signed
#6951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `an` to `a` in ERC 1271, as it precedes `signed`. I believe this was just a typo. I also noticed the clause: > considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract And think "signers" may be a typo, or I may just be misinterpreting the sentence.
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
an to a in ERC 1271, as it precedes signedan to a in ERC 1271, as it precedes signed
|
The commit 513ad56 (as a parent of 76310b7) contains errors. |
@Pandapip1 it looks like I figured it made sense to restrict this PR to just fixing the typo, but if you want me to make the changes recommended by those tools i can do so too |
|
The reason @eth-bot is blocking merging is because it requires more than one reviewer to make changes to final EIPs. Do not change anything else, or it will clear my approval. |
20 tasks
frangio
approved these changes
May 2, 2023
SamWilsn
approved these changes
May 4, 2023
eth-bot
approved these changes
May 4, 2023
axelcabee
pushed a commit
to axelcabee/EIPs
that referenced
this pull request
May 6, 2023
Change `an` to `a` in ERC 1271, as it precedes `signed`. I believe this was just a typo. I also noticed the clause: > considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract And think "signers" may be a typo, or I may just be misinterpreting the sentence.
axelcabee
pushed a commit
to axelcabee/EIPs
that referenced
this pull request
May 6, 2023
Change `an` to `a` in ERC 1271, as it precedes `signed`. I believe this was just a typo. I also noticed the clause: > considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract And think "signers" may be a typo, or I may just be misinterpreting the sentence.
alcedo
pushed a commit
to StraitsX/EIPs
that referenced
this pull request
Jun 13, 2023
Change `an` to `a` in ERC 1271, as it precedes `signed`. I believe this was just a typo. I also noticed the clause: > considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract And think "signers" may be a typo, or I may just be misinterpreting the sentence.
RaphaelHardFork
pushed a commit
to RaphaelHardFork/EIPs
that referenced
this pull request
Jan 30, 2024
Change `an` to `a` in ERC 1271, as it precedes `signed`. I believe this was just a typo. I also noticed the clause: > considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract And think "signers" may be a typo, or I may just be misinterpreting the sentence.
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
Change `an` to `a` in ERC 1271, as it precedes `signed`. I believe this was just a typo. I also noticed the clause: > considering that an *authorized* signers providing proper signatures for a given data would see their signature as "valid" by the signing contract And think "signers" may be a typo, or I may just be misinterpreting the sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
antoain ERC 1271, as it precedessigned. I believe this was just a typo.I also noticed the clause:
And think "signers" may be a typo, or I may just be misinterpreting the sentence.