Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta EIP for hard forks #233

Merged
merged 11 commits into from
Sep 18, 2018
Merged

Add meta EIP for hard forks #233

merged 11 commits into from
Sep 18, 2018

Conversation

axic
Copy link
Member

@axic axic commented Mar 23, 2017

No description provided.


The draft pull request shall be updated with summaries of the decisions around the hard fork. It should move in to `Accepted` state once the changes are frozen and in to the `Final` state once the hard fork has been activated.

The Yellow Paper should be kept updated with the hard fork changes. It could either refer to the fork codename or the EIP number of the fork.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth mentioning that it is a not a blocker for the activation to have an outdated Yellowpaper - if we follow the practice of today.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends if this is to be prescriptive or proscriptive. If the latter, then I would propose EIPs should be formalised as Yellow Paper revisions prior to implementation. This would help avoid the subtle consensus issues stemming from the informal nature of EIPs.

@Arachnid
Copy link
Contributor

Please renumber this as eip-233 and we can merge it as a draft.

@axic
Copy link
Member Author

axic commented Jul 3, 2017

@Arachnid this has been updated in April :)

@axic
Copy link
Member Author

axic commented Jul 28, 2017

@cdetrio is there anything to be added to this description to match how the meta EIPs are updated?

@Arachnid
Copy link
Contributor

This is a courtesy notice to let you know that the format for EIPs has been modified slightly. If you want your draft merged, you will need to make some small changes to how your EIP is formatted:

  • Frontmatter is now contained between lines with only a triple dash ('---')
  • Headers in the frontmatter are now lowercase.

If your PR is editing an existing EIP rather than creating a new one, this has already been done for you, and you need only rebase your PR.

In addition, a continuous build has been setup, which will check your PR against the rules for EIP formatting automatically once you update your PR. This build ensures all required headers are present, as well as performing a number of other checks.

Please rebase your PR against the latest master, and edit your PR to use the above format for frontmatter. For convenience, here's a sample header you can copy and adapt:

---
eip: <num>
title: <title>
author: <author>
type: [Standards Track|Informational|Meta]
category: [Core|Networking|Interface|ERC] (for type: Standards Track only)
status: Draft
created: <date>
---

@axic
Copy link
Member Author

axic commented Sep 4, 2018

@Arachnid @Souptacular Updated to reflect changes over the last year. I think this is OK to be merged as a draft now.

@axic
Copy link
Member Author

axic commented Sep 14, 2018

@Arachnid @Souptacular please advise what to do with this EIP

@Souptacular Souptacular merged commit ef22a93 into ethereum:master Sep 18, 2018
@axic axic deleted the hardforks branch September 18, 2018 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants