Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta-EIP] A process for finalizing Metropolis/Byzantium EIPs #687

Closed
wants to merge 1 commit into from

Conversation

cdetrio
Copy link
Member

@cdetrio cdetrio commented Aug 14, 2017

This Meta-EIP (or "process EIP") describes a process for documenting the finalization of EIPs included in the upcoming Byzantium hard fork. Following a previous meta-proposal (#233), the Finalization Table proposed here will be added to the Byzantium meta-EIP.

Copy link
Contributor

@Souptacular Souptacular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Souptacular
Copy link
Contributor

Souptacular commented Aug 14, 2017

Needs EIP # though.

@cdetrio cdetrio mentioned this pull request Aug 15, 2017
* The EIP text should specify the tentative values for all constants (except the activation block) used in implementations and tests, including assigned instructions (for opcodes), addresses (for precompiles), gas costs, etc.
* When an EIP is otherwise `Complete` but the text does not conform to the above standards, editors are expected to make the edits needed for approval.
* Once an EIP is `Complete`, it is merged (if still an open PR). All links to the EIP (e.g. from the README) are updated to reference the merged file.
* An EIP's status is upgraded from `Complete` to `Finalized` after a consensus decision at an AllCoreDevs meeting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually Final is used instead of Finalized in the status fiied of EIPs.

@@ -0,0 +1,102 @@
```
EIP: <tbd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 687 and move this file to EIPS/eip-687.md

@pirapira pirapira added the meta label Dec 1, 2017
@Arachnid
Copy link
Contributor

This is a courtesy notice to let you know that the format for EIPs has been modified slightly. If you want your draft merged, you will need to make some small changes to how your EIP is formatted:

  • Frontmatter is now contained between lines with only a triple dash ('---')
  • Headers in the frontmatter are now lowercase.

If your PR is editing an existing EIP rather than creating a new one, this has already been done for you, and you need only rebase your PR.

In addition, a continuous build has been setup, which will check your PR against the rules for EIP formatting automatically once you update your PR. This build ensures all required headers are present, as well as performing a number of other checks.

Please rebase your PR against the latest master, and edit your PR to use the above format for frontmatter. For convenience, here's a sample header you can copy and adapt:

---
eip: <num>
title: <title>
author: <author>
type: [Standards Track|Informational|Meta]
category: [Core|Networking|Interface|ERC] (for type: Standards Track only)
status: Draft
created: <date>
---

@axic
Copy link
Member

axic commented Sep 20, 2018

@cdetrio do you want to instead update EIP-233 and create a PR against it?

@Arachnid
Copy link
Contributor

Closing as obsolete.

@Arachnid Arachnid closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants