Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating EIP 2515 for clarity. #2605

Closed
wants to merge 8 commits into from
Closed

Conversation

MadeofTin
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP header in EIPS/eip-2515.md does not match: 2512

@@ -1,6 +1,6 @@
---
eip: 2512
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this merged with the wrong number in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. It confuses me.

EIPS/eip-2515.md Outdated Show resolved Hide resolved
EIPS/eip-2515.md Outdated Show resolved Hide resolved
@axic
Copy link
Member

axic commented Apr 17, 2020

All these fields are broken:

created: 2020/02/10
requires (*optional):
replaces (*optional):

MadeofTin and others added 3 commits April 17, 2020 09:22
eip: 2512
title: Implement Difficulty Freeze
eip: 2515
title: Update Difficulty Bomb with a Freezing Mechanism
author: James Hancock (@madeoftin)
discussions-to: https://ethereum-magicians.org/t/eip-2515-replace-the-difficulty-bomb-with-a-difficulty-freeze/3995
status: Draft
type: Standards Track
category: Core
created: 2020/02/10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
created: 2020/02/10
created: 2020-02-10

EIPS/eip-2515.md Outdated


## Motivation
<!--The motivation is critical for EIPs that want to change the Ethereum protocol. It should clearly explain why the existing protocol specification is inadequate to address the problem that the EIP solves. EIP submissions without sufficient motivation may be rejected outright.-->
The current difficulty bombs' effect on the Block Time Targeting mechanism is rather complex to model, and it has both appeared when it was not expected (Muir Glacier) and negatively affected miners when they are not the target (in the case of delaying forks due to technical difficulties). Miners are affected by a reduction in block rewards due to the increase in block time. Users are affected as a function of the usability of the chain is affected by increased block times. Both of these groups are unable on their own to address the difficulty bomb. In the case of the Difficulty Freeze, the consequences of missing it are more directly felt by the client maintainers and it is more predictiable and so knowing when to make the change is readily apparent.
The current difficulty bombs' effect on the Block Time Targeting mechanism is rather complex to model, and it has both appeared when it was not expected (Muir Glacier) and negatively affected users and miners when they are not the target (in the case of delaying forks due to technical difficulties). Users are affected as a function of the usability of the chain is affected by increased block times. Miners are affected by a reduction in block rewards due to the increase in block time. Both of these groups are unable on their own to address the difficulty bomb. In the case of the Difficulty Freeze it is more predictiable and so knowing when to make the change is readily apparent at all times.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a single difficulty bomb:

Suggested change
The current difficulty bombs' effect on the Block Time Targeting mechanism is rather complex to model, and it has both appeared when it was not expected (Muir Glacier) and negatively affected users and miners when they are not the target (in the case of delaying forks due to technical difficulties). Users are affected as a function of the usability of the chain is affected by increased block times. Miners are affected by a reduction in block rewards due to the increase in block time. Both of these groups are unable on their own to address the difficulty bomb. In the case of the Difficulty Freeze it is more predictiable and so knowing when to make the change is readily apparent at all times.
The current difficulty bomb's effect on the Block Time Targeting mechanism is rather complex to model, and it has both appeared when it was not expected (Muir Glacier) and negatively affected users and miners when they are not the target (in the case of delaying forks due to technical difficulties). Users are affected as a function of the usability of the chain is affected by increased block times. Miners are affected by a reduction in block rewards due to the increase in block time. Both of these groups are unable on their own to address the difficulty bomb. In the case of the Difficulty Freeze it is more predictable and so knowing when to make the change is readily apparent at all times.

EIPS/eip-2515.md Outdated Show resolved Hide resolved
Added more sections and a major updates section to chronicle them.
Co-authored-by: Alex Beregszaszi <[email protected]>
@axic
Copy link
Member

axic commented Sep 10, 2020

@MadeofTin you need to click the "Resolve conflicts" button and manually fix the issues, otherwise this can not be merged:
Screenshot

@lightclient
Copy link
Member

Pinging @MadeofTin.

@github-actions
Copy link

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Nov 29, 2020
@github-actions
Copy link

github-actions bot commented Dec 6, 2020

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants