Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misformatted fields in EIP-2515 #2756

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Conversation

lightclient
Copy link
Member

Current output from eip-validator:

Warning: EIPS/eip-2515.md        undefined method `requires (*optional)=' for #<EipValidator::Validator:0x0000557ce931cf48>

Additionally, it appears that the assigned EIP is incorrect as #2512 is unrelated.

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP header in EIPS/eip-2515.md does not match: 2512
  • EIP 2515 requires approval from one of (@MadeofTin)

@axic
Copy link
Member

axic commented Jun 29, 2020

Reported these issues on #2605 and they were introduced in #2515.

@axic
Copy link
Member

axic commented Jun 29, 2020

This fixes build/validation issues so I'm merging it.

@axic axic changed the title Fix EIP-2515 Fix invalid fields in EIP-2515 Jun 29, 2020
@axic axic changed the title Fix invalid fields in EIP-2515 Fix misformatted fields in EIP-2515 Jun 29, 2020
@axic axic merged commit bd7016d into ethereum:master Jun 29, 2020
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
* remove requires and replaces field

* fix assigned eip for 2515

* remove comments and update date format
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
* remove requires and replaces field

* fix assigned eip for 2515

* remove comments and update date format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants