Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ERC1967 to Final (Last call deadline reached) #5035

Merged
merged 3 commits into from
May 17, 2022
Merged

Move ERC1967 to Final (Last call deadline reached) #5035

merged 3 commits into from
May 17, 2022

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Apr 24, 2022

No description provided.

@eth-bot
Copy link
Collaborator

eth-bot commented Apr 24, 2022 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-1967.md

classification
updateEIP
  • passed!

@Amxx Amxx changed the title Make ERC1967 final as per the end of the last call period Move ERC1967 to Final (Last call deadline reached) Apr 24, 2022
SamWilsn
SamWilsn requested changes Apr 30, 2022
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #5061

@poojaranjan poojaranjan mentioned this pull request May 3, 2022
Closed
@lightclient
Copy link
Member

lightclient commented May 3, 2022 •
edited
Loading

New deadline is 2022-05-14 - can you please fix the conflicts in the meantime?

@poojaranjan poojaranjan mentioned this pull request May 17, 2022
Closed
lightclient
lightclient approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 501968c into ethereum:master May 17, 2022
@Amxx Amxx deleted the ERC1967/final branch May 18, 2022 14:35
PowerStream3604 pushed a commit to PowerStream3604/EIPs that referenced this pull request May 19, 2022
@Amxx @PowerStream3604
Move ERC1967 to Final (Last call deadline reached) (ethereum#5035)
f61826e 
* Make ERC1967 final as per the end of the last call period

* Make ERC1967 final as per the end of the (second) last call period
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@Amxx @nachomazzara
Move ERC1967 to Final (Last call deadline reached) (ethereum#5035)
e9a2d20 
* Make ERC1967 final as per the end of the last call period

* Make ERC1967 final as per the end of the (second) last call period
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn requested changes

@spalladino spalladino spalladino approved these changes

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Amxx @eth-bot @lightclient @spalladino @SamWilsn