Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4844: clarify to must be non-nil #7100

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

lightclient
Copy link
Member

@karalabe raised a concern that the current transaction type spec in 4844 is not clear on whether a nil to field is allowed. This PR aims at clarifying any confusion around the correct representation of blob txs.

@lightclient
Copy link
Member Author

nice number

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels May 31, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 31, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title 4844: clarify to must be non-nil Update EIP-4844: clarify to must be non-nil May 31, 2023
g11tech
g11tech previously approved these changes May 31, 2023
adietrichs
adietrichs previously approved these changes Jun 1, 2023
Copy link
Member

@adietrichs adietrichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EIPS/eip-4844.md Outdated Show resolved Hide resolved
@lightclient lightclient marked this pull request as ready for review June 1, 2023 14:12
@lightclient lightclient requested a review from eth-bot as a code owner June 1, 2023 14:12
@eth-bot eth-bot enabled auto-merge (squash) June 1, 2023 14:13
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@lightclient lightclient marked this pull request as draft June 1, 2023 14:13
auto-merge was automatically disabled June 1, 2023 14:13

Pull request was converted to draft

@lightclient lightclient marked this pull request as ready for review June 1, 2023 14:25
@lightclient lightclient closed this Jun 1, 2023
@lightclient lightclient reopened this Jun 1, 2023
@eth-bot eth-bot enabled auto-merge (squash) June 1, 2023 14:26
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants