Handle empty aggregation bits as discussed in #1713 #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
added
scope:CI/tests/pyspec
post-freeze (substantive)
protolambda
force-pushed
the
empty-bits-case
branch
from
9458547
to
47ed5b6
Compare
|
Note that this change is a bit at odds with the comment here -- #1732 (comment) If we go through with this PR and with #1732, we should probably explicitly disallow 0-participation aggregates on the gossip layer |
djrtwo
reviewed
May 4, 2020
tests/core/pyspec/eth2spec/test/phase_0/epoch_processing/test_process_rewards_and_penalties.py
Outdated
Show resolved
Hide resolved
hwwhww
reviewed
May 7, 2020
djrtwo
approved these changes
May 7, 2020
25 tasks
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1713
Marking this as substantive, since it technically breaks existing behavior, if there is any attestation with 0 participants on-chain.
In the process of making the empty-participants case invalid, some tests didn't make sense anymore. Others were broken. Removed the invalid tests, fixed the broken ones, and added more testing (mostly related to rewards/penalties participation changes, re-using functions of the empty/almost-empty cases)
Edit: forced push 2nd commit that handles additional tests. Changed rng seeding to be different between test cases.