Update p2p reqresp with explicit handling of reqresp size bounds #1800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update p2p doc to:
Related, now that we are looking more critically at the req-resp payload format/sizing:
I see we have both:
Can we maybe remove the second one? It's nice ascii, but this and the sudden introduction of "A response therefore has the form ..." after going in-depth a lot already feels double to me. And the optional header is confusing with the earlier BNF. The header can be empty if the encoding strategy doesn't need any header data, that's all.
Edit: above duplicate section has been removed. The BNF-like diagram already has this exact information. And
result
being one byte is explained as part of the responding side.Force push edit: bounds are now described as
type size bounds
instead oftype bounds