Some phase1 refactoring #1854

hwwhww · 2020-05-28T14:02:27Z

Per #1850 request

Rename head_shard_root to shard_head_root
Rework is_shard_attestation
- Different from Prysm phase 1 feedback #1850 suggested, I changed it to is_on_time_attestation so that it could be reused in validate_attestation
Rename verify_shard_transition_false_positives to verify_empty_shard_transition

Change it to `is_on_time_attestation` so that it could be reused in `validate_attestation`.

…rd_transition`

terencechain · 2020-05-28T14:46:46Z

Looks good to me. Thanks!

specs/phase1/beacon-chain.md

Co-authored-by: Danny Ryan <[email protected]>

hwwhww added 3 commits May 28, 2020 21:38

Rename head_shard_root to shard_head_root

ca48963

Rework is_shard_attestation

8c9bbc4

Change it to `is_on_time_attestation` so that it could be reused in `validate_attestation`.

Rename verify_shard_transition_false_positives to `verify_empty_sha…

1926288

…rd_transition`

hwwhww added phase1 general:presentation Presentation (as opposed to content) labels May 28, 2020

hwwhww mentioned this pull request May 28, 2020

Rework Shard transition processing #1856

Merged

hwwhww requested a review from djrtwo May 28, 2020 19:31

djrtwo reviewed May 28, 2020

View reviewed changes

specs/phase1/beacon-chain.md Outdated Show resolved Hide resolved

PR feedback from Danny

b16e6d7

Co-authored-by: Danny Ryan <[email protected]>

djrtwo approved these changes May 31, 2020

View reviewed changes

hwwhww merged commit 8f570b4 into dev Jun 1, 2020

hwwhww deleted the hwwhww/phase1_refactor branch June 1, 2020 09:47

Provide feedback