Rework Shard transition processing
#1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
force-pushed
the
hwwhww/verify_empty_shard_transition
branch
from
5695cb9
to
0aec204
Compare
hwwhww
commented
May 28, 2020
| ###### Updated `process_attestation` | ||
|
|
||
| ```python | ||
| def process_attestation(state: BeaconState, attestation: Attestation) -> None: |
There was a problem hiding this comment.
To reviewers: only moving the function block to here. Nothing was changed in this function.
| @@ -695,7 +696,7 @@ def process_operations(state: BeaconState, body: BeaconBlockBody) -> None: | |||
| # See custody game spec. | |||
| process_custody_game_operations(state, body) | |||
|
|
|||
| process_crosslinks(state, body.shard_transitions, body.attestations) | |||
| process_shard_transitions(state, body.shard_transitions, body.attestations) | |||
There was a problem hiding this comment.
Would be neat to convert to:
for_ops(body.shard_transitions, body.attestations, process_shard_transitions)
But it doesn't look feasible today 😅
There was a problem hiding this comment.
But for_ops is mainly for executing operation one-by-one, and we need all body.shard_transitions and body.attestations to process crosslinks.
… `process_shard_transitions`
hwwhww
force-pushed
the
hwwhww/verify_empty_shard_transition
branch
from
0aec204
to
327deb4
Compare
djrtwo
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending on #1854
New Attestation processinsection andShard transition processingsectionprocess_crosslinksandverify_empty_shard_transitionintoprocess_shard_transitionsverify_empty_shard_transitionreturnboolas otherverify_*functions/cc @terencechain