-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIPs to CFI, based on ACD150 #656
Conversation
Codecov ReportBase: 68.75% // Head: 72.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
==========================================
+ Coverage 68.75% 72.04% +3.29%
==========================================
Files 481 518 +37
Lines 26836 29051 +2215
==========================================
+ Hits 18451 20930 +2479
+ Misses 8385 8121 -264
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
||
* [EIP-3651: Warm COINBASE](https://eips.ethereum.org/EIPS/eip-3651) | ||
* [EIP-3855: PUSH0 instruction](https://eips.ethereum.org/EIPS/eip-3855) | ||
* [EIP-3860: Limit and meter initcode](https://eips.ethereum.org/EIPS/eip-3860) | ||
* [EIP-4895: Beacon chain push withdrawals as operations](https://eips.ethereum.org/EIPS/eip-4895) | ||
|
||
### EIPs Considered for Inclusion | ||
Specifies changes potentially included in the Network Upgrade, pending successful deployment on Client Integration Testnets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the change in definition warrants a reclassification of those EIPs already in this category, for example i think transient storage was CFI for shanghai meaning that assuming it did not delay shanghai or present issues during testing it would be included, but this change makes that far less clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moodysalem in the interest of providing an accurate view of where things are at sooner rather than later, I think I'd merge it as is. On the next ACD, I expect we'll have a clear list of what's included in Shanghai and a rough idea of what to do about other EIPs. It makes sense to revamp CFI for the next fork (as we do a bunch of other process changes as well). For 1153 specifically, I don't think it should change what we do: next step is to get it on devnets along with everything else!
Decided on ethereum/pm#662