Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate formatting middlewares to Method formatters #1209

Closed
wants to merge 3 commits into from
Closed

Migrate formatting middlewares to Method formatters #1209

wants to merge 3 commits into from

Conversation

dylanjw
Copy link
Contributor

@dylanjw dylanjw commented Jan 15, 2019 •
edited
Loading

What was wrong?

Based on: #1166

Related to Issue #1161 and #1057

TODO:

  • pythonic_middleware
  • attrdict_middleware middleware
  • request_param_normalizer middleware
  • validation_middleware
  • abi_middleware

Cute Animal Picture

image

@dylanjw dylanjw force-pushed the async_api_formatters branch 5 times, most recently from 0709f77 to 421950a Compare January 16, 2019 05:32
@dylanjw dylanjw mentioned this pull request Jan 16, 2019
Closed
@dylanjw dylanjw force-pushed the async_api_formatters branch 5 times, most recently from 5f60251 to b97db6a Compare January 16, 2019 09:53
@pipermerriam
Copy link
Member

waiting for #1166 to land before looking this over.

dylanjw
dylanjw commented Jan 17, 2019
View reviewed changes
web3/manager.py
(pythonic_middleware, 'pythonic'), # Delete
(normalize_errors_middleware, 'normalize_errors'), # Add async
(validation_middleware, 'validation'), # Add async
(abi_middleware, 'abi'), # Delete
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are notes to myself. Will remove.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylanjw I am planning on taking this over shortly if you don't have objections! When I was looking this over, it looks like the attrdict_middleware didn't get moved over. I assume that the plan is to shift it still? Or did you run into something where it didn't make sense any more?

Copy link
Contributor Author

@dylanjw dylanjw Oct 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan at this time was to move the attrdict_middleware functionality to the method formatters later. I didnt run into any complications.

@dylanjw
Copy link
Contributor Author

dylanjw commented Jan 17, 2019

I broke out the commit re #1197. I will put it in a pull request once this is merged.

@dylanjw
Copy link
Contributor Author

dylanjw commented Feb 2, 2019

This is ready for review.

@kclowes kclowes added this to the Async Web3 API milestone Aug 7, 2019
@kclowes kclowes mentioned this pull request Sep 27, 2019
Merged
1 task
@kclowes
Copy link
Collaborator

kclowes commented Nov 21, 2019

Moved these commits over to #1461. Closing here.

@kclowes kclowes closed this Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Async Web3 API
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanjw @pipermerriam @kclowes