Async formatters #1461
Merged
Async formatters #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
async-api-formatters-ii
branch
2 times, most recently
from
99c3f2b
to
b385c2c
Compare
pipermerriam
approved these changes
Sep 27, 2019
kclowes
force-pushed
the
async-api-formatters-ii
branch
from
fe8c0c6
to
ebe5b19
Compare
kclowes
commented
Nov 1, 2019
kclowes
force-pushed
the
async-api-formatters-ii
branch
5 times, most recently
from
026dd77
to
1740e3a
Compare
kclowes
force-pushed
the
async-api-formatters-ii
branch
from
81a2bac
to
4d2a0d4
Compare
pipermerriam
approved these changes
Nov 11, 2019
| except TypeError: | ||
| raise ValueError("input_munger expects a 3-tuple") | ||
|
|
||
| def input_munger(self, module, args, kwargs): | ||
| # TODO: Create friendly error output. | ||
| mungers_iter = iter(self.mungers) | ||
| root_munger = next(mungers_iter) |
There was a problem hiding this comment.
I know this code wasn't changed, but it strikes me as something that is in need of a nice comment explaining what it is doing as it is quite cryptic at-a-glance.
kclowes
force-pushed
the
async-api-formatters-ii
branch
from
3b62fb3
to
8db82b2
Compare
kclowes
added a commit
to kclowes/web3.py
that referenced
this pull request
Nov 13, 2019
kclowes
force-pushed
the
async-api-formatters-ii
branch
from
8db82b2
to
71ba5f1
Compare
kclowes
force-pushed
the
async-api-formatters-ii
branch
from
71ba5f1
to
9f7c882
Compare
kclowes
force-pushed
the
async-api-formatters-ii
branch
from
9f7c882
to
a103b60
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Updates #1209 to most recent master since it was opened so long ago.
Related to Issue #1413
How was it fixed?
Pulled in master and updated tests.
Todo:
Cute Animal Picture