Fix example for adding local_filter_middleware to middlewares #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
approved these changes
Feb 23, 2019
docs/middleware.rst
Outdated
| @@ -383,7 +383,7 @@ retrieved using JSON-RPC endpoints that don't rely on server state. | |||
| >>> from web3 import Web3, EthereumTesterProvider | |||
| >>> w3 = Web3(EthereumTesterProvider) | |||
There was a problem hiding this comment.
I think EthereumTesterProvider should have parens too?
w3 = Web3(EthereumTesterProvider())
dylanjw
force-pushed
the
fix_filter_doc
branch
from
6c6d172
to
3e3e7dc
Compare
docs/middleware.rst
Outdated
| @@ -381,9 +381,9 @@ retrieved using JSON-RPC endpoints that don't rely on server state. | |||
| .. code-block:: python | |||
There was a problem hiding this comment.
Can we update these to be doctests so we catch these types of errors in CI. Probably good to revert the changes and confirm the doctest failures and then re-apply the fixes to ensure that doctest is doing what it's supposed to.
|
@dylanjw do you have time to convert this to a doctest? No worries if not :) |
|
@kclowes I will try to get to it later this week. |
kclowes
force-pushed
the
fix_filter_doc
branch
from
3e3e7dc
to
6afbd1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1244
How was it fixed?
Removed the parentheses.
Cute Animal Picture